Fix broken Kubernetes stack flags #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to be defined in the "persistent space". Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #831 +/- ##
=======================================
Coverage 52.95% 52.95%
=======================================
Files 244 244
Lines 15828 15828
=======================================
Hits 8382 8382
Misses 6892 6892
Partials 554 554 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
I fixed the broken kubernetes stack flags
namespaceandkubeconfig.- How I did it
I switched PersistentFlags to Flags while reading flags during the command
runphase.- How to verify it
docker stack ls --namespace myemptynamespaceshould print nothing- Description for the changelog
Fix broken Kubernetes stack flags
- A picture of a cute animal (not mandatory but encouraged)
